Support custom port for Calls #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpoile
approved these changes
Oct 10, 2023
phoinixgrr
approved these changes
Oct 11, 2023
cpoile
reviewed
Oct 11, 2023
Comment on lines
+32
to
+33
| - ${CALLS_PORT}:${CALLS_PORT}/udp | ||
| - ${CALLS_PORT}:${CALLS_PORT}/tcp |
There was a problem hiding this comment.
One qq for my own learning: if you don't set this var, what does docker-compose do?
There was a problem hiding this comment.
@cpoile There is a default so one would have to explicitly unset it. But if you did then you'd get a bunch of warnings and eventually a failure:
WARNING: The CALLS_PORT variable is not set. Defaulting to a blank string.
ERROR: The Compose file './docker-compose.nginx.yml' is invalid because:
services.mattermost.ports contains an invalid type, it should be a number, or an object
services.mattermost.ports contains an invalid type, it should be a number, or an object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I realized that the way this was set we weren't really supporting anything other than the default
8443. Now we rewrite the port on both sides so that it's forwarded correctly.