Added a stand and draft receiver case #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch slots into hole in the front of case. It has a slot for the switch specified in the BOM and a pincer for a top mount switch.
Had them backward in first commit
Angles are 8 degrees of tilt and 8 degrees of roll. Comfy for me, but could add others.
mattdibi
requested changes
Jun 27, 2020
There was a problem hiding this comment.
Thank you for your contribution. Those STLs are awesome!
I have a request though: keymaps, with the exception of the testing ones provided in this repo, should reside in the QMK firmware repository.
I would then suggest you to remove the following files:
- redox_w_layout_mine.hex
- redox_w_layout_mine.json
- chris_map.pdf
and contribute with this keymap to the QMK firmware repository instead.
Added nice snap fittings to the receiver case and made the angle stand a lot cleaner, and sections to put non-slip feet on
|
Pretty new to contributing to open source, so let me know if i've done this right. On my fork I've removed those files, plus made some more updates to the .STLs. I think I've updated the pull request to reflect that, but if I need to change further, let me know and I'll figure out how to. |
mattdibi
approved these changes
Jul 5, 2020
|
It's all merged now, thank you for your contribution ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed the IO on the switch as I had it backward initially