Document the Mill-Max and Peel-A-Way hotswap mod #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
striveFar
pushed a commit
to striveFar/redox-keyboard
that referenced
this pull request
Jan 29, 2022
* Add delay between setting a column pin and reading out the row Currently, the way we do matrix scans in the two halfs can give rise to race conditions. In the loop we set a column pin and in the next cycle we read the the row. As a result we might be reading the input before the singals stabilize. This change adds a nop that allows a cycle between the two operations. In addition, this patch remove a workaround that made the local variable volatile in an attempt to fix this. Signed-off-by: Nikos Nikoleris <[email protected]> * Reduce the use of global variables Signed-off-by: Nikos Nikoleris <[email protected]> * Eliminate the use of a second rtc Previously the two halfs used 2 separate RTCs, the 1st configured at 8Hz and the 2nd configured at 1000Hz. There is no real reason to have both RTCs turned on; the 1st one ticks on every 125th tick of the 2nd one. This change eliminates the use of the 1st RTC. Signed-off-by: Nikos Nikoleris <[email protected]> * Clean-up inactivity detection code Signed-off-by: Nikos Nikoleris <[email protected]> * Rename the rtc and tick handler Now that there is only one RTC and a single tick function generalise their renames to reflect their functions. Signed-off-by: Nikos Nikoleris <[email protected]> * Factor out code that handles debounce in a separate function Signed-off-by: Nikos Nikoleris <[email protected]> * Refactor to simplify debouncing code Signed-off-by: Nikos Nikoleris <[email protected]> * Eliminate the maintainance function Previously the maintainance function would make sure that continuous key presses send multiple updates to the receiver. This is not necessary as the debounce logic will achieve the same thing. Every DEBOUNCE ticks where the row values have been stable, the keyboard half sends it to the receiver. Signed-off-by: Nikos Nikoleris <[email protected]> * Simplify the send process and further reduce global variables Signed-off-by: Nikos Nikoleris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.