Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activating a plugin should fail when the plugin has missing dependencies #10542

Merged
merged 1 commit into from
Sep 23, 2016
Merged

Activating a plugin should fail when the plugin has missing dependencies #10542

merged 1 commit into from
Sep 23, 2016

Conversation

mattab
Copy link
Member

@mattab mattab commented Sep 23, 2016 •
edited
Loading

  • when using plugin:activate console command: before it looked like the plugin:activate command worked but it actually didn't work. Now we output a clear error message.
  • also added the text to the notification: reuse

Replaces #10401

@mattab mattab added this to the 3.0.0-b1 milestone Sep 23, 2016
@mattab mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Sep 23, 2016
@mattab mattab self-assigned this Sep 23, 2016
@mattab mattab merged commit 3a5ce5a into 3.x-dev Sep 23, 2016
@mattab mattab deleted the activate_plugin_fail_when_missing_deps branch September 23, 2016 04:20
mattab added a commit that referenced this pull request Sep 23, 2016
@mattab
Fixes regression introduced in #10542
c89a7bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mattab mattab

Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
3.0.0-b1
Development

Successfully merging this pull request may close these issues.
1 participant
@mattab