Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: chg: solve vulns #28

Merged
merged 7 commits into from
Oct 5, 2023
Merged

dev: chg: solve vulns #28

merged 7 commits into from
Oct 5, 2023

Conversation

marcello33
Copy link

@marcello33 marcello33 commented Oct 4, 2023 •
edited
Loading

This PR bumps some dependencies to solve reported vulnerabilities, and change code in some places to make it compatible with new libraries.

This was referenced Oct 4, 2023
Merged
Merged
@marcello33 marcello33 requested a review from a team October 4, 2023 12:02
Raneet10
Raneet10 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@Raneet10 Raneet10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mostly, just some minor questions.

@marcello33
Copy link
Author

Thanks for the comments @Raneet10

I deleted those portions of code because the implementation with the new package requires some effort and we need to release the patch asap. It is safe as both these functions (serializeSig and signatureFromBytes) are only used in TestSignatureVerificationAndRejectUpperS. The complete test suite runs successfully.

@marcello33 marcello33 merged commit 2bb6a83 into peppermint Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssandeep ssandeep ssandeep approved these changes

@Raneet10 Raneet10 Raneet10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@marcello33 @ssandeep @Raneet10 @VAIBHAVJINDAL3012