Fix issue 245 #247
Merged
Fix issue 245 #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
New tests. Cool. I love it. |
matepek
approved these changes
Dec 14, 2020
|
I meant remove just the date not the version bump. Well, no worries I will increase it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In Catch2 v3 tests with tags, the parser was accidentally skipping the next element (test case), causing some tests to be missed.
Which issue(s) this PR fixes:
Fixes #245
Special notes for your reviewer:
Some additional tests were added in the cpp sample project to allow verification in integration test mode.
(updated to version 3.6.16 -- ready for release)