Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable shellcheck warnings for x-prefix comparison and unreachable code #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sgallagher
Copy link
Contributor

@sgallagher sgallagher commented Feb 22, 2023

ShellCheck version 0.8.0 returns non-zero for x-prefix comparisons and version 0.9.0 returns non-zero for unreachable code (such as the shift appearing in the generated parse_commandline() function).

This patch just disables these checks.

ShellCheck now returns non-zero for these warnings, causing the tests to fail.
This just excludes them from the checks.

Signed-off-by: Stephen Gallagher <[email protected]>
@sgallagher sgallagher changed the title Disable shellcheck warning for x-prefix comparison Disable shellcheck warnings for x-prefix comparison and unreachable code Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant