use arrays for tests #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat
approved these changes
Mar 14, 2021
| {URL: "https://aws.amazon.com/favicon.ico", Width: 16, Height: 16, Format: "ico", Bytes: 1150, Sha1sum: "a64f3616e3671b835f8b208b7339518d8b386a08"}, | ||
| func TestFetchIcons(t *testing.T) { | ||
| tests := []testFetch{ | ||
| // alibaba - base tag without scheme |
There was a problem hiding this comment.
Maybe even worthwhile to treat this as data by adding it as e.g. testName to testFetch?
There was a problem hiding this comment.
Not a bad idea. Only reason I didn't was because I was trying to keep that first line a reasonable length. I'll poke around a bit more for the next PR.
There was a problem hiding this comment.
Sure, just a thought, judge for yourself in we Gaia anything from it :–)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the tests into arrays so they are all handled in the same way. This is prep for adding a bunch more tests from the top1000. For each icon, I check the url, size and format. I also made it so that the VCR path is inferred from the URL host.