Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change source attribute of Suggestion entity in /api/v2/suggestions back to a string #29108

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

ClearlyClaire
Copy link
Contributor

The new array is now in the sources attribute.

Fixes #29071

…ons` back to a string

The new array is now in the `sources` attribute.

Fixes #29071
@ClearlyClaire ClearlyClaire added the api REST API, Streaming API, Web Push API label Feb 6, 2024
@ClearlyClaire
Copy link
Contributor Author

cc @VyrCossont

@ClearlyClaire ClearlyClaire marked this pull request as ready for review February 6, 2024 13:17
@VyrCossont
Copy link
Contributor

Thanks, this should work.

@ClearlyClaire ClearlyClaire requested a review from a team February 6, 2024 16:40
renchap
renchap previously approved these changes Feb 6, 2024
Copy link
Sponsor Member

@renchap renchap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, docs will need to be updated.

@ClearlyClaire ClearlyClaire added this pull request to the merge queue Feb 6, 2024
@ClearlyClaire ClearlyClaire removed this pull request from the merge queue due to a manual request Feb 6, 2024
@ClearlyClaire
Copy link
Contributor Author

Removed from the merge queue as I missed the necessary front-end changes.

@ClearlyClaire ClearlyClaire added this pull request to the merge queue Feb 6, 2024
Merged via the queue into main with commit 7ee93b7 Feb 6, 2024
43 of 44 checks passed
@ClearlyClaire ClearlyClaire deleted the fixes/suggestions-breaking-api-change branch February 6, 2024 17:15
skerit pushed a commit to 11ways/mastodon that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api REST API, Streaming API, Web Push API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: Suggestion.source is documented as a string, currently returns list of strings
3 participants