Fix audio player volume control on Safari #23187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Quickly looking over the change, it seems fine, but I am unable to replicate the issue it aims to fix. Which browser did you encounter the issue with? |
I am using Safari 16.2 on macOS 13.1 (22C65). I think the issue will be replicable on iOS or iPadOS, but I did not tested on these OSes. |
Gargron
approved these changes
Jan 23, 2023
4dd7642
to
7794784
Compare
|
I've verified that existing code works fine in other major browsers. Now fixes an issue where the effect of Gain may be applied twice (because of volume of HTMLAudioElement) |
2 tasks
383ed0a
to
0763d0b
Compare
minacle
commented
Jan 23, 2023
0763d0b
to
0eabae7
Compare
ClearlyClaire
requested changes
Jan 24, 2023
0eabae7
to
633b12e
Compare
ClearlyClaire
approved these changes
Jan 24, 2023
minacle
referenced
this pull request
in uri-life/mastodon
Jan 24, 2023
btrd
pushed a commit
to btrd/mastodon
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<Audio> is playing audio using AudioContext, not using HTMLAudioElement directly.
Therefore, changing volume and muted of HTMLAudioElement are not working at all.
This PR makes <Audio> to handle volume change correctly by using GainNode for it.