Remove support for Ruby 2.6 #21477
Merged
Remove support for Ruby 2.6 #21477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As pointed out by mastodon#21297 (comment) at least one of our dependencies already dropped support for Ruby 2.6, and we had removed Ruby 2.6 tests from the CI over a year ago (mastodon#16861). So stop advertising Ruby 2.6 support, bump targeted version, and drop some compatibility code.
connorshea
approved these changes
Nov 23, 2022
casaper
approved these changes
Nov 23, 2022
|
I know in practice this is already broken, but should this be considered a formally 'breaking' change? |
|
EOL was 7 months ago. So it's kind of out of warranty, but "we" can obviously highlight it. |
In this particular case, I wouldn't mark it as breaking, as it's been broken already. |
ykzts
approved these changes
Nov 24, 2022
Closed
nametoolong
pushed a commit
to nametoolong/nuage
that referenced
this pull request
Jan 12, 2023
As pointed out by mastodon#21297 (comment) at least one of our dependencies already dropped support for Ruby 2.6, and we had removed Ruby 2.6 tests from the CI over a year ago (mastodon#16861). So stop advertising Ruby 2.6 support, bump targeted version, and drop some compatibility code. # Conflicts: # README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by #21297 (comment) at least one of our dependencies already dropped support for Ruby 2.6, and we had removed Ruby 2.6 tests from the CI over a year ago (#16861).
So stop advertising Ruby 2.6 support, bump targeted version, and drop some compatibility code.