Fix N+1 queries in NotificationsController #21202
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #19319, the
noindex
attribute is added toAccountSerializer
. The field is defined in the User model instead of the Account model, so an extra query will occur if the User model is not preloaded. The notifications controller returns the account associated with a notification, but does not preloadfrom_account.user
. Therefore, N+1 queries happen when rendering notifications.This PR fixes the issue by preloading
:user
inNotificationsController#load_notifications
.