Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change settings area to be separated into categories in admin UI #19407

Merged
merged 1 commit into from
Oct 22, 2022

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Oct 21, 2022

The settings are split into:

  • Branding
  • About
  • Registrations
  • Discovery
  • Content retention
  • Appearance

Furthermore:

  • "Server description" is removed, "Short server description" takes its place
  • Character limit of 200 on the new "Server description"
  • Removed the following settings (for limited applicability and not fitting into any other category neatly):
    • Publish aggregate statistics about user activity in the API
    • Publish list of discovered servers in the API
    • Show sensitive media in OpenGraph previews
  • Extended description now supports Markdown syntax

Screenshots

Screenshot 2022-10-21 at 20-20-14 Branding - Localhost (Dev)

Screenshot 2022-10-21 at 20-20-32 About - Localhost (Dev)

Screenshot 2022-10-21 at 20-20-38 Registrations - Localhost (Dev)

Screenshot 2022-10-21 at 20-20-44 Discovery - Localhost (Dev)

Screenshot 2022-10-21 at 20-20-53 Content retention - Localhost (Dev)

Screenshot 2022-10-21 at 20-21-21 Appearance - Localhost (Dev)

@Gargron Gargron added the moderation Administration and moderation tooling label Oct 21, 2022
@Gargron Gargron force-pushed the feature-admin-settings-tabs branch 2 times, most recently from cc68f28 to ce14dda Compare October 21, 2022 18:29
@Gargron Gargron merged commit 7c152ac into main Oct 22, 2022
@Gargron Gargron deleted the feature-admin-settings-tabs branch October 22, 2022 09:44
@ClearlyClaire
Copy link
Contributor

One thing I missed when reviewing and that is not mentioned in the PR comment was that the setting to disable indexing by default has been removed. Is it an oversight? If not, why was it removed?

@Gargron
Copy link
Member Author

Gargron commented Nov 9, 2022

Some things happened in the last 19 days that kind of make me blank on my exact thought process, but trying to recreate it now, I probably thought that it's strange to have an option for overriding a default user preference. If admins want their entire site to not be indexed, that option didn't do that, and then users would be able to override it on their profiles anyway. Would you like me to add an option that ensures that all pages have a noindex tag on them?

@ClearlyClaire
Copy link
Contributor

it's strange to have an option for overriding a default user preference

I guess, but it's also something that many feel strongly should not be opt-out.

If admins want their entire site to not be indexed, that option didn't do that, and then users would be able to override it on their profiles anyway. Would you like me to add an option that ensures that all pages have a noindex tag on them?

I don't think that's what admins want, I think it's more about it being opt-out rather than opt-in. But I guess such a setting could be a good thing too. Honestly I'm not sure what the best course of action would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
moderation Administration and moderation tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants