ip_cleanup_scheduler: Make IP and session retention configurable #18757
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6474, there are mentions of IP addresses being stored for too long (1 year). While this pull request doesn't allow disabling the storage of IP addresses, it would allow instance admins to limit the duration for which IP addresses are stored. In my Catstodon fork, I have deployed and tested these changes already, with success (with an IP address retention of 24 hours, and the Sidekiq job set to run every hour).
This pull request may require the following changes, but I am unsure how to best do them:
ip_cleanup_scheduler
sidekiq job should be run, instead of having to modify sidekiq.yml directly. Or perhaps deriving an optimal value it fromIP_RETENTION_PERIOD
.ip_cleanup_scheduler.rb
handles all of these.If this pull request is merged, the docs over at Configuring your environment will also need to be updated.