Add /api/v1/admin/domain_allows

[ClearlyClaire]

• GET /api/v1/admin/domain_allows lists allowed domains
• GET /api/v1/admin/domain_allows/:id shows one by ID
• DELETE /api/v1/admin/domain_allows/:id deletes a given domain from the list
  of allowed domains
• POST /api/v1/admin/domain_allows to allow a new domain:
  if that domain is already allowed, the existing DomainAllow will be returned

Limited federation mode counterpart to #18247.

The “domain allow” terminology is awkward but it's the one we've been using internally since the feature has been created. To my knowledge, it's the first time we actually expose it to users/admins, so it might be a good time to come up with a better terminology, although I can't think of anything that would fit the “domain block” terminology.

---

This project was funded through the NGI0 Discovery Fund, a fund established by NLnet with financial support from the European Commission's Next Generation Internet programme, under the aegis of DG Communications Networks, Content and Technology under grant agreement No 825322.

[digitalcircuit]

Other than "domain allows", two potential counterparts to "domain blocks" come to mind:

1. "domain permits" (or "permitted domains"?)
2. "domain grants"

[ClearlyClaire]

I'm not completely convinced by “domain grants” but it's better than “domain allows” in my opinion. “Allowed domains” would work, though that breaks the symmetry with “domain blocks”… but maybe that isn't really an issue?

[shleeable]

domain_blocklist vs domain_allowlist makes more sense.

domain_peers follows the BGP terminology.

Approved. Trusted. Promoted. Accepted. vested. chosen. endorsed. permitted. supported. validated.

[ClearlyClaire]

domain_blocklist vs domain_allowlist makes more sense.

The APIs for domain blocks are already /api/v1/domain_blocks/ (for user domain blocks) and /api/v1/admin/domain_blocks/ (although the latter is in main but in no release, so we could still change it I guess.

domain_peers is follows the BGP terminology.

Approved. Trusted. Promoted. Accepted. vested. chosen. endorsed. permitted. supported. validated.

You've listed adjectives but if we want to be consistent with domain_blocks it should be a noun! domain_peers and domain_approvals could kind of work.

[trwnh]

domains_allowed? that would be the proper plural form

[ClearlyClaire]

Well, that would be consistent with domains_blocked, not domain_blocks. I don't think domains_allowed would have an advantage over allowed_domains. I think allowed_domains is fine but it doesn't mirror domain_blocks though.