Fix suspicious sign-in mails never being sent #18599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
approved these changes
Jun 3, 2022
|
@Gargron ping |
kadoshita
pushed a commit
to kadoshita/mastodon
that referenced
this pull request
Nov 19, 2022
* Add tests * Fix suspicious sign-in mails never being sent
ClearlyClaire
added a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Jul 6, 2023
* Add tests * Fix suspicious sign-in mails never being sent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17970 has replaced sign-in token verification by warning emails.
However, the log-in activity record was created before checking for suspicious log-ins, so logins were never considered suspicious.
Additionally, a much trickier reason that logins where never considered suspicious is that log-in actually happens before
Auth::SessionsController#createis called. This is caused by theLocalizedconcern being included (throughDevise::FailureApp.send :include, Localized) and usingcurrent_userin aaround_actionhook. This is why the suspicious login test is now performed in a prependedbefore_actionhook.The added tests account for both these reasons.