Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setting that disables account deletes #17683

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Remove setting that disables account deletes #17683

merged 1 commit into from
Oct 6, 2022

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Mar 2, 2022

No description provided.

@Gargron Gargron force-pushed the fix-remove-deletion-setting branch from 3f2e45f to 55ed851 Compare March 3, 2022 20:53
@ClearlyClaire ClearlyClaire requested review from ClearlyClaire and removed request for ClearlyClaire March 7, 2022 15:05
ClearlyClaire
ClearlyClaire requested changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, I have reviewed this a bit fast. I believe the current code immediately deletes the account with all of its data, while we should probably keep it for a short time to let the person change their mind or let moderators some time to handle the situation.

(I believe this is why this is still marked as a Draft, but I wanted to explain my reasoning behind the “Request changes”, sorry for the noise)

@Gargron
Copy link
Member Author

Gargron commented Mar 8, 2022

I don't disagree that introducing a grace period would be a good change, but it is not why this is a draft. I simply forgot to toggle it. I think this should be mergeable without adding any new features.

@Gargron Gargron marked this pull request as ready for review March 8, 2022 04:30
@stale
Copy link

stale bot commented Jul 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/wontfix This will not be worked on label Jul 10, 2022
@stale stale bot closed this Jul 31, 2022
@Gargron Gargron reopened this Oct 5, 2022
@Gargron Gargron force-pushed the fix-remove-deletion-setting branch from 55ed851 to 56bf11d Compare October 5, 2022 22:37
@Gargron Gargron removed the status/wontfix This will not be worked on label Oct 6, 2022
ClearlyClaire
ClearlyClaire approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think there should be a short grace period, but this is somewhat orthogonal to this PR.

@Gargron Gargron merged commit 93f340a into main Oct 6, 2022
@Gargron Gargron deleted the fix-remove-deletion-setting branch October 6, 2022 08:16
lindwurm added a commit to akane-blue/mastodon that referenced this pull request Oct 28, 2022
@lindwurm
Revert "Remove setting that disables account deletes (mastodon#17683)"
e87307e 
This reverts commit 93f340a.

Signed-off-by: lindwurm <[email protected]>
kadoshita pushed a commit to kadoshita/mastodon that referenced this pull request Nov 19, 2022
@Gargron @kadoshita
Remove setting that disables account deletes (mastodon#17683)
fe8dadb
nametoolong pushed a commit to nametoolong/nuage that referenced this pull request Nov 20, 2022
@Gargron
Remove setting that disables account deletes (mastodon#17683)
49bfc36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClearlyClaire ClearlyClaire ClearlyClaire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gargron @ClearlyClaire