Fix ordering of keyboard access between CW field, textarea and emoji picker #11066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this change, single column EmojiPicker will scroll out. Although the placement of EmojiPicker on the DOM may not be appropriate, EmojiPicker is a tool to support input, so it should not always be displayed? (The Advanced UI EmojiPicker also scrolls out, but it should also be visible at all times) Is there a good solution? |
|
Hm, at least that's not a regression with regards to last release… I wonder how it could be achieved… |
Gargron
approved these changes
Jun 13, 2019
Gargron
approved these changes
Jun 13, 2019
koba-lab
pushed a commit
to koba-lab/mastodon
that referenced
this pull request
Jun 14, 2019
* commit 'c9eeb2e832b5b36a86028bbec7a353c32be510a7': (227 commits) Bump version to 2.9.0 (mastodon#11074) New Crowdin translations (mastodon#11075) New Crowdin translations (mastodon#11073) Fix ordering of keyboard access between CW field, textarea and emoji picker (mastodon#11066) List attachments in reply indicator and boost modal (mastodon#10997) New Crowdin translations (mastodon#11069) Bump version to 2.9.0rc2 (mastodon#11070) Do not expand toot when clicking on a poll option (mastodon#11067) Only show profile directory link when it's enabled (mastodon#11064) Add button to conveniently copy OAuth code (mastodon#11065) Fix border-bottom of active tab bars (mastodon#11068) New Crowdin translations (mastodon#11062) Change translations badge in README to Crowdin (mastodon#11054) New Crowdin translations (mastodon#11060) Fix Serbian pluralization rules requiring a "many" key (mastodon#11061) Update crowdin.yml i18n: Update Japanese translations (mastodon#11035) Update Crowdin configuration file Update Crowdin configuration file l10n: update Persian translations (fa.yml) (mastodon#11052) ... # Conflicts: # CHANGELOG.md # app/javascript/mastodon/components/status.js # app/javascript/mastodon/locales/ja.json # app/javascript/styles/mastodon-light/diff.scss # db/schema.rb # lib/mastodon/version.rb # package.json
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
messenjahofchrist
pushed a commit
to Origin-Creative/mastodon
that referenced
this pull request
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.