Add config for MASTODON_USE_LIBVIPS #1463
Open
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmstan
changed the title
ClearlyClaire
approved these changes
Jun 18, 2024
renchap
reviewed
Jun 19, 2024
| @@ -42,7 +42,7 @@ echo "deb [signed-by=/usr/share/keyrings/postgresql.asc] http:https://apt.postgresql.o | |||
| ```bash | |||
| apt update | |||
| apt install -y \ | |||
| imagemagick ffmpeg libpq-dev libxml2-dev libxslt1-dev file git-core \ | |||
| imagemagick ffmpeg libvips-tools libpq-dev libxml2-dev libxslt1-dev file git-core \ | |||
There was a problem hiding this comment.
Should we really have people install both here? It do not feel useful. Maybe let's keep the instructions for IM only for now, and switch them to vips for 4.4 when it becomes the default?
There was a problem hiding this comment.
So here's my rationale on this: because on Debian most of imagemagick gets installed when you install libvips, including it makes only a small impact and makes it easier to enable the option later if they want to try it and less friction when it switches to become default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for mastodon/mastodon#30090
Merge as part of Mastodon 4.3 release