Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark MediaAttachment.preview_url, blurhash as nullable #1457

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Mark MediaAttachment.preview_url, blurhash as nullable #1457

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf6d79e
Mark MediaAttachment.preview_url as nullable
humblehacker Jun 3, 2024
7ab1bd1
Mark MediaAttachment.blurhash as nullable
humblehacker Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Mark MediaAttachment.preview_url as nullable 
Had a payload in the wild where preview_url was `null` and the method that generates this value can certainly return `nil` if none of its conditions are met: https://github.com/mastodon/mastodon/blob/d326ad0ed9a2e874213c9313f25b973638e4b94d/app/serializers/rest/media_attachment_serializer.rb#L30-L38

Also both TootSDK and IceCubesApp have this property as nullable.
  • Loading branch information
@humblehacker
humblehacker committed Jun 3, 2024
commit cf6d79e222c443e8935542611040cf5d03d14d4f
2 changes: 1 addition & 1 deletion content/en/entities/MediaAttachment.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ aliases: [
### `preview_url` {#preview_url}

**Description:** The location of a scaled-down preview of the attachment.\
**Type:** String (URL)\
**Type:** {{<nullable>}} String (URL)\
**Version history:**\
0.6.0 - added

Expand Down