Update admin/domain_blocks to include conflict response #1417
Conversation
When creating a domain block, if there is already a domain block rule for the domain, then the existing block is returned. This documents that behavior. I've also documented the `digest` property which was added in mastodon/mastodon#29092
| } | ||
| ``` | ||
|
|
||
| ##### 422: Unprocessable entity - Existing Domain Block |
There was a problem hiding this comment.
Arguably this shouldn't be a 422 but instead a 409 conflict, I'm not sure how easy that would be to change though, since the 422 is existing behaviour.
|
|
||
| ```json | ||
| { | ||
| "error": "You have already imposed stricter limits on example.com." |
There was a problem hiding this comment.
This is also misleading kind of: The check is just "do we have a domain block for any of the variants of example.com", it doesn't actually check that the block that is found is "stricter" than the requested block to create.
i.e., if you have a block for foo.example.com where you want to suspend, but you already have a block for example.com which is a silence, then you cannot create foo.example.com's block with suspend, because the rule for example.com prevents you.
There was a problem hiding this comment.
That does sound like a bug, we may want to let people block subdomains of domains they have merely limited, and that is something the admin interface allows afaict
There was a problem hiding this comment.
Yeah, the logic is definitely different: https://github.com/mastodon/mastodon/blob/main/app/controllers/admin/domain_blocks_controller.rb#L31
There was a problem hiding this comment.
In IFTAS FediCheck we basically had to reimplement the domain block redundancy code, and comparing severity.
i've also an issue to add webhooks to federation management (would certainly be also good to know when a new domain is noticed, but this is much harder to implement )
When creating a domain block, if there is already a domain block rule for the domain, then the existing block is returned. This documents that behavior.
I've also documented the
digestproperty which was added in mastodon/mastodon#29092