Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination - next link for page in parent section #1391

Closed
wants to merge 5 commits into from

Conversation

jhauga
Copy link

@jhauga jhauga commented Jan 16, 2024

At the bottom of the content added a link to work as pagination for the section.

At the bottom of the content added a link to work as pagination for the section.
Copy link

vercel bot commented Jan 16, 2024

@jhauga is attempting to deploy a commit to the Mastodon Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Author

@jhauga jhauga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matched link formatting as named links appear in documentation.

At the bottom of the content added two links to work as pagination for the section.
At the bottom of the content added two links to work as pagination for the section.
At the bottom of the content added two links to work as pagination for the section.
At the bottom of the content added a link to work as pagination for the section.
Copy link
Author

@jhauga jhauga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked that links match.

As this seems to be a section that reads in sequential order, thought pagination links would improve page.

Copy link
Member

@trwnh trwnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't be done by modifying the content. it should be done by modifying the theme.

@jhauga
Copy link
Author

jhauga commented Jan 17, 2024

this shouldn't be done by modifying the content. it should be done by modifying the theme.

Ok. I'm gonna close this pull request then and open another one when done.

@jhauga jhauga closed this Jan 17, 2024
@jhauga jhauga deleted the patch-1 branch January 17, 2024 17:04
@jhauga
Copy link
Author

jhauga commented Feb 19, 2024

this shouldn't be done by modifying the content. it should be done by modifying the theme.

Opened a new pull request #1395. This enables sequential navigation on mostly all pages, excluding nested API Method pages in the "API Methods" section.

Working Example:
Also to see a working demo I made a support repo documentation-sequential-links. It works using "Codespaces". My goto is php -S localhost:8000.

To Expand:
Per testing locally - the links successfully updated consistently for me; excluding nested API Method pages mentioned above. I made a support repo with a working example - documentation-sequential-links. You'll have to use "Codesapces" then localhost it. I used php -S localhost:8000, GitHub prompts with link, and a working (mostly) example.

With the "Codespaces" localhost, the links in section "API Entities" go to a table-of-contents like page, but this happens when clicking on side nav and clicking on sequential nav built from pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants