Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for nginx certbot instructions #1036

Merged
merged 2 commits into from
Oct 5, 2023
Merged

fix for nginx certbot instructions #1036

merged 2 commits into from
Oct 5, 2023

Conversation

brookmiles
Copy link
Contributor

fix for #940

filmaj
filmaj approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I had this same issue when setting up my new instance and the instructions in this PR helped me set it up correctly 👍

ThisIsMissEm
ThisIsMissEm reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@ThisIsMissEm ThisIsMissEm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to comment that it might be good to replace example.com with instance.example, given the .example TLD is explicitly reserved for examples.. but it turns out example.com is also explicitly reserved:

(more just a TIL thing)

@ClearlyClaire ClearlyClaire merged commit 8a2cfbb into mastodon:master Oct 5, 2023
@brookmiles brookmiles deleted the fix-nginx-ssl-setup branch October 5, 2023 08:45
This was referenced Dec 10, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThisIsMissEm ThisIsMissEm ThisIsMissEm left review comments

@filmaj filmaj filmaj approved these changes

@Gargron Gargron Gargron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@brookmiles @ThisIsMissEm @filmaj @Gargron @ClearlyClaire