-
-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: DateTime fields, fix ISO 8601 type #1241
Comments
Hey there, I'd like to work on this issue as a beginner. Can you please guide me a little if my approach is correct? |
The wikipedia article for ISO 8601 states "If necessary for a particular
application, the standard supports the addition of a decimal fraction to
the smallest time value in the representation.". I'm not sure that we
should make such a wide-ranging change just because some languages have a
buggy implementation.
…On Thu, Jul 6, 2023 at 2:15 PM Rhythm Garg ***@***.***> wrote:
Hey there, I'd like to work on this issue as a beginner. Can you please
guide me a little if my approach is correct?
From what I can understand, I just need to find all the text ISO 8601 and
just replace it with RFC 3339 (with fractional seconds)?
—
Reply to this email directly, view it on GitHub
<#1241 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABZCV6IVL25Q62TN7IAVSDXO4FEFANCNFSM6AAAAAAZ5ADTDU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Java and PHP are hardly "some" languages... but I did some research, turns out it's complete chaos - moment.js in the JS world is a lenient parser that does accept sub-second precision timestamps, Python relies on whatever an user's Personally I don't care too much, but I think referring to a standard that can be openly read without paying 129€ for a copy would be more appropriate. |
All documentation (e.g.
entities/Account.md
) state thatDateTime
fields are in ISO 8601 format.This however is a bit misleading, given that at least Java and PHP specify "ISO" as a format in which the
second
has no fraction and thus leads to parsing errors if a programmer naively selects the predefined ISO 8601 format string. Besides, the ISO 8601 standard is not publicly available.Therefore I suggest to replace all mentions of "ISO 8601" by "RFC 3339 (with fractional seconds)".
The text was updated successfully, but these errors were encountered: