Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pico8-ls #2365

Merged
merged 6 commits into from
Aug 8, 2023
Merged

feat: add pico8-ls #2365

merged 6 commits into from
Aug 8, 2023

Conversation

kikito
Copy link
Contributor

@kikito kikito commented Aug 5, 2023 •
edited
Loading

Adding support for PICO-8 by using https://github.com/japhib/pico8-ls/

Solves japhib/pico8-ls#34
Related - git tags needed in pico8-ls for better renovate support japhib/pico8-ls#45

@williambotman williambotman requested a review from a team August 5, 2023 17:50
@kikito kikito mentioned this pull request Aug 5, 2023
Open
williamboman
williamboman approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@williamboman williamboman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be much better if they simply provided an npm package for it!

packages/pico8-ls/package.yaml Outdated Show resolved Hide resolved
packages/pico8-ls/package.yaml Outdated Show resolved Hide resolved
packages/pico8-ls/package.yaml Show resolved Hide resolved
@williamboman williamboman changed the title feat: add pico8-ls support feat: add pico8-ls Aug 8, 2023
@williamboman williamboman merged commit 1589642 into mason-org:main Aug 8, 2023
19 checks passed
@kikito kikito deleted the pico8-ls branch August 10, 2023 08:12
@kikito
Copy link
Contributor Author

kikito commented Aug 10, 2023

I think it'd be much better if they simply provided an npm package for it!

Agreed! Thank you for the merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamboman williamboman williamboman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kikito @williamboman