Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lucky command #88

Merged
merged 4 commits into from
Jan 28, 2018
Merged

Lucky command #88

merged 4 commits into from
Jan 28, 2018

Conversation

pablopunk
Copy link
Contributor

@pablopunk pablopunk commented May 11, 2017

So, when I install apps, like 90% of the times I know I'm gonna install the one that appears in the first result of mas search. That's why I always wanted a I'm feeling lucky feature.

Basically, it's a new command that searches an app name and installs the first result.

$ mas lucky twitter
==> Downloading Twitter
==> Installed Twitter

EDIT
As a workaround, you can use this

@pablopunk
Copy link
Contributor Author

The tests are failing because the build process doesn't find xcpretty. Travis is not configured to have this so I guess I shouldn't commit here the fix for this.

@phatblat phatblat mentioned this pull request May 23, 2017
@phatblat
Copy link
Member

Build is fixed in #91

@pablopunk
Copy link
Contributor Author

This repo isn't maintained very often is it?

@phatblat
Copy link
Member

Nope. I reached out to @rodionovd a few weeks ago via email and offered help, but I haven't received a response.

@pablopunk
Copy link
Contributor Author

Oh, I was thinking about doing that... I think there would be a lot of people interested in collaborate on this

@phatblat
Copy link
Member

I'm tempted to try to release from a fork but I don't know what the process is for changing ownership of a brew formula

@rodionovd
Copy link
Contributor

rodionovd commented Jun 29, 2017

@pablopunk @phatblat

I'm sooo sorry that I haven't reached back to you folks — it's been a few crazy months for me but I'm back now and will go through all of the issues/PRs within next few days.

I really appreciate your patience and your hard work on those PRs ❤️ You're awesome!

@pablopunk
Copy link
Contributor Author

This doesn't seem to be maintained anymore. If anyone is interested on this feature, what I do is having this function on my ~/.bash_profile:

function masl {
  mas search $1 | head -n1 | awk '{print $1;}' | xargs mas install
}

And then use it like:

$ masl Twitter

@phatblat
Copy link
Member

@pablopunk the master branch has been updated to Swift 4 and after merging into your branch there are a couple of syntax errors. Could you fix those up so that I can merge this PR? Thanks!

@pablopunk
Copy link
Contributor Author

@phatblat nice! I will do it

@phatblat phatblat merged commit d11b72a into mas-cli:master Jan 28, 2018
@phatblat
Copy link
Member

Thanks, @pablopunk! This new command will go out in 1.4

@pablopunk
Copy link
Contributor Author

pablopunk commented Jan 28, 2018

@phatblat Awesome! Almost a year later 😄. I see you took over this repo, nice.

BTW I have no idea about Swift, I coded this basically copying Install and Search commands, so now it's only duplicated code. It works but it should be refactored to prevent code duplication.

@pablopunk pablopunk deleted the lucky-command branch January 28, 2018 00:13
@phatblat
Copy link
Member

Could have fooled me! No worries about the duplicated code. I'll be doing some refactoring soon, but wanted to get the great features that have been waiting a long time into this great project.

@phatblat phatblat added this to the 1.4 milestone Jan 28, 2018
This was referenced Feb 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants