-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/client generates a 500 error #1
Comments
Thanks. I pushed new code for the /client URL this morning; is this run using commit c3553b1 ? ("git log -n1" should tell you) |
…t. Improve logging in ClientGetter to get to the bottom of #1
I'm having trouble reproducing this, so I just pushed some changes to both martifacts and boom that will hopefully provide some more helpful info in the logs. If you don't mind trying again can you repeat the test and post the log output here? Thanks! |
Have a clear error now, should be easy to fix now (either on my side, either on yours, haven't checked the code yet).
|
Aha! Yes, that's super-helpful. I would not have guessed that to be the line causing the issue. Should be able to resolve this tonight. In the meantime you can just download the client from here: https://github.com/martylamb/martifacts/blob/master/src/main/resources/client/martifacts But you'll need to edit line 4 so that the "URL" var points to your server (basically the URL of the web interface). |
Don't worry i tryed the .sh client before (manually indeed) and it's working. At a very quick glance, the problem may just be that i'm running (in a docker container) with a classpath only populated with jars (thus the code should be getResourceAsStream()) and when starting in dev the file is accessible directly from the filesystem (thus getResource()). |
…. just use a bufferedreader instead so there's no Path use and thus (hopefully) no FileSystemNotFoundException. Also change path for client download from /client to /martifact so that various downloaders (I'm looking at you wget) will name the downloaded file correctly.
Okay i confirm that client downloading is working without error now since f7df25a commit (downloaded file named "martifacts", without .sh) |
That's great. Thanks much for helping to test this. |
…t. Improve logging in ClientGetter to get to the bottom of #1
…. just use a bufferedreader instead so there's no Path use and thus (hopefully) no FileSystemNotFoundException. Also change path for client download from /client to /martifact so that various downloaders (I'm looking at you wget) will name the downloaded file correctly.
At this time on my side i get a 500 internal error when clicking on the /client URL as generated in the index.html.
Corresponding logs are :
The text was updated successfully, but these errors were encountered: