Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some reader functionality expansions & minor improvements #2

Merged
merged 2 commits into from
Jul 17, 2017
Merged

Some reader functionality expansions & minor improvements #2

merged 2 commits into from
Jul 17, 2017

Conversation

Algomorph
Copy link
Contributor

  1. Added a Pangolin-based reader that can process any pangolin URI that has a depth and rgb stream.
  2. Added GeForce GTX 780 thread / block stats.
  3. A few minor typo fixes

1) Added a Pangolin-based reader that can process any pangolin URI that has a depth and rgb stream.
2) Added GeForce GTX 780 thread / block stats.
3) A few minor typo fixes
@martinruenz
Copy link
Owner

Cool, I never used this Pangolin functionality, but I think this can be useful for others as well.

Have you tested the code? I am getting the following compile error:

/co-fusion/GUI/Tools/PangolinReader.cpp:99:12: error: no match for ‘operator=’ (operand types are ‘std::unique_ptr<pangolin::VideoInterface>’ and ‘pangolin::VideoInterface*’)
  interface = pangolin::OpenVideo(this->uri);

@Algomorph
Copy link
Contributor Author

@martinruenz , I have tested the code. Perhaps the difference is that you're still using an older version of Pangolin. Could you try pulling Lovegrove's version, master branch, and trying it with that? I think it will work with the code in the PR, since that's what I'm using.

@martinruenz
Copy link
Owner

I see. The build script actually clones a modified version of pangolin, which allows to remove variables again. Since I am not making use of this feature in Co-Fusion (although I was planning to), switching to the Pangolin master-branch is a viable option. I'll think about this and probably merge your request later today / tomorrow.

@martinruenz martinruenz merged commit e37d49d into martinruenz:master Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants