Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agent option #3

Merged
merged 1 commit into from
Feb 1, 2018
Merged

Add agent option #3

merged 1 commit into from
Feb 1, 2018

Conversation

fastfedora
Copy link
Contributor

Add an option to use an SSH agent to provide a private key instead of specifying the private key explicitly using the privateKey option. This is useful is you are using encrypted private keys managed by an ssh-agent process.

Add an option to use an SSH agent to provide a private key instead
of specifying the private key explicitly using the `privateKey`
option.
@broerse
Copy link
Collaborator

broerse commented Jan 31, 2018

I was not aware that there is an agent option in the underlying modules. Is it passed to all the way to ssh2 ?

@fastfedora
Copy link
Contributor Author

Yes, the options are passed down through sftp-upload to scp2 to ssh2. You can see the full list of options here.

Rather than add each option individually as it's needed, you could also just pass all the options passed into this plugin into Sftp and they should flow all the way down. That would allow people with other configurations to use the plugin without adding new parameters.

I didn't have time to do this re-factoring, since all I needed was the agent option, but it should be pretty easy.

@broerse
Copy link
Collaborator

broerse commented Feb 1, 2018

Thanks will merge. Will release new version later.

@broerse broerse merged commit 11dd937 into martinic:master Feb 1, 2018
@broerse
Copy link
Collaborator

broerse commented Feb 1, 2018

Released v0.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants