Deferring #394
Merged
Deferring #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… default but optional, and removed file_writer from files without writing
pckroon
requested changes
Dec 6, 2021
Added changes in martinize2. |
pckroon
approved these changes
Dec 7, 2021
|
The failing test is hypothesis finding a unicorn, pylint failure seems a bug in pylint, since the score should be more than high enough, docs failure seems due to a change in nx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes file_writer.open to file_writer.deferred_open and adds defer_writing=TRUE as boolean keyword argument to writing functions, so as to allow both direct as well as deferred writing (e.g. in write_pdb). Overwriting the function 'open' with file_writer.DeferredWriter().open was never a good idea.