Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ffinput multiple links #246

Merged
merged 2 commits into from
Apr 15, 2020

Conversation

fgrunewald
Copy link
Member

Fix to issue #243 and some light linting. There are still quite some unused variables and overwritten functions and stuff pylint complains about. But that would require linting all parsers starting with the parser_utilities and then all sub-classes thereof.

@pckroon Shall I make a separate issue?

Copy link
Member

@pckroon pckroon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the tiny comments.

Feel free to open issues as you see fit, those are cheap.

vermouth/ffinput.py Show resolved Hide resolved
vermouth/ffinput.py Show resolved Hide resolved
vermouth/ffinput.py Show resolved Hide resolved
vermouth/ffinput.py Show resolved Hide resolved
@fgrunewald fgrunewald requested a review from pckroon April 12, 2020 07:26
@pckroon pckroon merged commit 4dfda06 into marrink-lab:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants