preserve meta when converting block to molecule #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pckroon seems like the doc building fails. Locally the doc is built without problems including '-EnW'. Can you try to build it and see, if there is an issue for you. |
|
You may need to add a -A (or -a?) flag locally to make sure you build all the docs, and not just the files that changed. |
pckroon
approved these changes
Apr 7, 2020
pckroon
requested changes
Apr 7, 2020
pckroon
previously approved these changes
Apr 15, 2020
|
Still some tiny pep8 issues, but if you don't feel like fixing them it's fine as-is |
pckroon
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to the function to_molecule to preserve the meta data of the block. Fixes issue #244.