Makebonds molecule #234
Closed
Makebonds molecule #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 4, 2020 16:25
…n_system method of the Processor base class.
mjtadema
force-pushed
the
makebonds_molecule
branch
from
eba1107
to
848ce74
Compare
|
Is this superseded by #222? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are my changes to make bonds. The CLI flag is also included here.
I added an argument group for experimental arguments, might come in handy for some other stuff as well.
I tested this on my system in combination with #233 and i get the same behavior as before.
I didn't change any other processors yet but indeed it should be much easier now to implement multiprocessing in any other processor that has a run_molecule method.