Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage index settings in Vespa application package #921

Merged
merged 50 commits into from
Oct 3, 2024

Conversation

papa99do
Copy link
Collaborator

@papa99do papa99do commented Jul 28, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Reliability improvements

  • What is the current behavior? (You can also link to an open issue here)

  • Index settings are maintained in a Vespa schema, which has consistency issue
  • Marqo config is stored as a document in Vespa
  • Vespa Bootstrapping is done once-off
  • What is the new behavior (if this is a feature change)?
  • Index settings are maintained within the Vespa application package
  • Marqo config is stored within the Vespa application package
  • Bootstrapping of the Vespa app is done automatcially on every Marqo release
  • Provided a way to safely rollback to the previous version of Marqo
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No, there are no changes to the external APIs or customer-facing behaviour of Marqo

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    Yes

  • Related Python client changes (link commit/PR here)
    N/A

  • Related documentation changes (link commit/PR here)
    N/A

  • Other information:

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@papa99do papa99do force-pushed the yihan/update-index-settings branch from 1246404 to 4664309 Compare August 5, 2024 08:57
@papa99do papa99do force-pushed the yihan/update-index-settings branch from 5b444b8 to 88a14f5 Compare August 6, 2024 11:58
@papa99do papa99do changed the title [DRAFT]Consistent Index settings change Manage index settings in Vespa application package Aug 6, 2024
@papa99do papa99do force-pushed the yihan/update-index-settings branch from 88a14f5 to 3e280ff Compare August 6, 2024 23:36
requirements.dev.txt Outdated Show resolved Hide resolved
@papa99do papa99do merged commit 78d8227 into mainline Oct 3, 2024
8 of 9 checks passed
@papa99do papa99do deleted the yihan/update-index-settings branch October 3, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants