Reject promise in checkError with logoutUser: false and without redirectTo causes an error #10172 #10177
+10
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectTo causes an error marmelab#10172
|
Hi, thanks for contributing. Can you please first explain the issue? |
|
Hi ,
As per understanding this issue is caused when redirect is null for some
use cases they don't want to redirect but using this to display an error
message.
…On Mon, Sep 2, 2024, 8:58 AM Gildas Garcia ***@***.***> wrote:
Hi, thanks for contributing. Can you please first explain the issue?
—
Reply to this email directly, view it on GitHub
<#10177 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEO463T6UPCA3YI4OJWNHX3ZURVIHAVCNFSM6AAAAABNOKDW3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRUHAZDGNBUGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add null check for redirect and When redirect is not provided, I returned false and let the called handles the redirect.
This may not be ideal solution, happy to discuss as this is my my first contribution.
Fixes #10172