draft-next "contains", "minContains", "maxContains", and related "unevaluatedProperties" support #95
Conversation
"contains" now supports both objects and arrays, and while it produces the same annotations, it now reads annotations from minContains and maxContains, which no are no longer assertions. "contains" now also impacts "unevaluatedProperties", so that keyword gets a new version as well. This also removes the need to ever un-fail another keyword's result, although the pass_() method still has other internal uses.
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
- Coverage 92.06% 91.17% -0.89%
==========================================
Files 21 21
Lines 2003 2039 +36
Branches 427 434 +7
==========================================
+ Hits 1844 1859 +15
- Misses 101 122 +21
Partials 58 58
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Oh, now I remember why I didn't post these- only the draft-next tests will cover the changes, so the code cov fails. I had plans to add infrastructure to test draft-next but skip the unimplemented tests, but I never got around to that. |
|
This needs significant rework based on comments in #80 about keyword class organization. I'll move it off of "draft" status once that's done. |
Fixes #93. I was cleaning up local branches and realized I never posted this one. I don't expect this to go into 0.10.1 but (like the PRs I rebased today) I had to put the CHANGELOG entry somewhere. I expect to rebase and move it whenever appropriate.
"contains" now supports both objects and arrays, and while it produces the same annotations, it now reads annotations from
minContains and maxContains, which no are no longer assertions.
"contains" now also impacts "unevaluatedProperties", so that keyword gets a new version as well.
This also removes the need to ever un-fail another keyword's result, although the pass_() method still has other internal uses.