Modifying to newer Arduino Library format …

[MikeAlger]

Hi Mark
I appreciated using your library last year in a course demonstrating radio communications to undergraduate students, and I noticed you recently moved files around to support Arduino library formats a bit better. Last year I spent some time adapting your code to the 1.5 version of the Arduino library and I thought I could provide those changes to you so you can easily upgrade the library to newest and greatest, without to much trouble

Mike

ps. I apologize for the formatting of this pull request I'm a bit more familiar with the mark up used by Gitlab

---

The Library specification can be found here

This modification :

• Reorganizes the location of library files to the src folder
• Adds a src.ino file to allow viewing and editing files within the Arduino IDE.
• Adds .development file which should be removed to write protect the library from users playing with the library files unintentionally.
• Adds a filled out library properties as best as I can figure them out.
• Adds the micromodem documentation in the extras folders to provide users a circuit schematic,

Futurework

• A keywords file can be added later to help highlight structures used by the software, but I feel @markqvist may be able to better sort what is exposed the user and is useful to them

[markqvist]

Thanks a bunch for providing this!

[markqvist]

Hi Mike! Thanks so much for providing that pull request. Sorry it took me a while to get to it, I've been really busy wrapping everything up for the launch of my new product, RNode. Best regards, Mark

…

On 26 Jun 2018, at 16.28, MikeAlger ***@***.***> wrote: Hi Mark I appreciated using your library last year in a course demonstrating radio communications to undergraduate students, and I noticed you recently moved files around to support Arduino library formats a bit better. Last year I spent some time adapting your code to the 1.5 version of the Arduino library and I thought I could provide those changes to you so you can easily upgrade the library to newest and greatest, without to much trouble Mike ps. I apologize for the formatting of this pull request I'm a bit more familiar with the mark up used by Gitlab The Library specification can be found here <https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification> This modification : Reorganizes the location of library files to the src folder Adds a src.ino file to allow viewing and editing files within the Arduino IDE. Adds .development file which should be removed to write protect the library from users playing with the library files unintentionally. Adds a filled out library properties as best as I can figure them out. Adds the micromodem documentation in the extras folders to provide users a circuit schematic, Futurework A keywords file can be added later to help highlight structures used by the software, but I feel @markqvist <https://github.com/markqvist> may be able to better sort what is exposed the user and is useful to them You can view, comment on, or merge this pull request online at: #14 <#14> Commit Summary Modifying to newer Arduino Library format specifed in https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification File Changes A .development <https://github.com/markqvist/LibAPRS/pull/14/files#diff-0> (0) A extras/MicroModem_Manual_v3.pdf <https://github.com/markqvist/LibAPRS/pull/14/files#diff-1> (0) A library.properties <https://github.com/markqvist/LibAPRS/pull/14/files#diff-2> (10) R src/AFSK.cpp <https://github.com/markqvist/LibAPRS/pull/14/files#diff-3> (2) R src/AFSK.h <https://github.com/markqvist/LibAPRS/pull/14/files#diff-4> (2) R src/AX25.cpp <https://github.com/markqvist/LibAPRS/pull/14/files#diff-5> (0) R src/AX25.h <https://github.com/markqvist/LibAPRS/pull/14/files#diff-6> (2) R src/CRC-CCIT.c <https://github.com/markqvist/LibAPRS/pull/14/files#diff-7> (2) R src/CRC-CCIT.h <https://github.com/markqvist/LibAPRS/pull/14/files#diff-8> (2) R src/FIFO.h <https://github.com/markqvist/LibAPRS/pull/14/files#diff-9> (2) R src/HDLC.h <https://github.com/markqvist/LibAPRS/pull/14/files#diff-10> (2) R src/LibAPRS.cpp <https://github.com/markqvist/LibAPRS/pull/14/files#diff-11> (0) R src/LibAPRS.h <https://github.com/markqvist/LibAPRS/pull/14/files#diff-12> (0) R src/constants.h <https://github.com/markqvist/LibAPRS/pull/14/files#diff-13> (2) R src/device.h <https://github.com/markqvist/LibAPRS/pull/14/files#diff-14> (2) A src/src.ino <https://github.com/markqvist/LibAPRS/pull/14/files#diff-15> (2) Patch Links: https://github.com/markqvist/LibAPRS/pull/14.patch <https://github.com/markqvist/LibAPRS/pull/14.patch> https://github.com/markqvist/LibAPRS/pull/14.diff <https://github.com/markqvist/LibAPRS/pull/14.diff> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABXxPAShBN6tDN4_mzMVc_vAcRyD7OtPks5uAkUAgaJpZM4U4Drh>.

[MikeAlger]

Hi Mark, no worries I kind of just dropped that on you without discussing it prior to submitting the pull request so its understandable. Good luck with RNode, I’ll give it a look after the docs are up and I find some time. Again thanks for putting this together in the first place it made my life much easier. Mike From: Mark Qvist <[email protected]> Sent: Friday, July 6, 2018 3:06 AM To: markqvist/LibAPRS <[email protected]> Cc: MikeAlger <[email protected]>; Author <[email protected]> Subject: Re: [markqvist/LibAPRS] Modifying to newer Arduino Library format … (#14) Hi Mike! Thanks so much for providing that pull request. Sorry it took me a while to get to it, I've been really busy wrapping everything up for the launch of my new product, RNode. Best regards, Mark

On 26 Jun 2018, at 16.28, MikeAlger ***@***.***> wrote: Hi Mark I appreciated using your library last year in a course demonstrating radio communications to undergraduate students, and I noticed you recently moved files around to support Arduino library formats a bit better. Last year I spent some time adapting your code to the 1.5 version of the Arduino library and I thought I could provide those changes to you so you can easily upgrade the library to newest and greatest, without to much trouble Mike ps. I apologize for the formatting of this pull request I'm a bit more familiar with the mark up used by Gitlab The Library specification can be found here <https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification> This modification : Reorganizes the location of library files to the src folder Adds a src.ino file to allow viewing and editing files within the Arduino IDE. Adds .development file which should be removed to write protect the library from users playing with the library files unintentionally. Adds a filled out library properties as best as I can figure them out. Adds the micromodem documentation in the extras folders to provide users a circuit schematic, Futurework A keywords file can be added later to help highlight structures used by the software, but I feel @markqvist <https://github.com/markqvist> may be able to better sort what is exposed the user and is useful to them You can view, comment on, or merge this pull request online at: #14 <#14> Commit Summary Modifying to newer Arduino Library format specifed in https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification File Changes A .development <https://github.com/markqvist/LibAPRS/pull/14/files#diff-0> (0) A extras/MicroModem_Manual_v3.pdf <https://github.com/markqvist/LibAPRS/pull/14/files#diff-1> (0) A library.properties <https://github.com/markqvist/LibAPRS/pull/14/files#diff-2> (10) R src/AFSK.cpp <https://github.com/markqvist/LibAPRS/pull/14/files#diff-3> (2) R src/AFSK.h <https://github.com/markqvist/LibAPRS/pull/14/files#diff-4> (2) R src/AX25.cpp <https://github.com/markqvist/LibAPRS/pull/14/files#diff-5> (0) R src/AX25.h <https://github.com/markqvist/LibAPRS/pull/14/files#diff-6> (2) R src/CRC-CCIT.c <https://github.com/markqvist/LibAPRS/pull/14/files#diff-7> (2) R src/CRC-CCIT.h <https://github.com/markqvist/LibAPRS/pull/14/files#diff-8> (2) R src/FIFO.h <https://github.com/markqvist/LibAPRS/pull/14/files#diff-9> (2) R src/HDLC.h <https://github.com/markqvist/LibAPRS/pull/14/files#diff-10> (2) R src/LibAPRS.cpp <https://github.com/markqvist/LibAPRS/pull/14/files#diff-11> (0) R src/LibAPRS.h <https://github.com/markqvist/LibAPRS/pull/14/files#diff-12> (0) R src/constants.h <https://github.com/markqvist/LibAPRS/pull/14/files#diff-13> (2) R src/device.h <https://github.com/markqvist/LibAPRS/pull/14/files#diff-14> (2) A src/src.ino <https://github.com/markqvist/LibAPRS/pull/14/files#diff-15> (2) Patch Links: https://github.com/markqvist/LibAPRS/pull/14.patch <https://github.com/markqvist/LibAPRS/pull/14.patch> https://github.com/markqvist/LibAPRS/pull/14.diff <https://github.com/markqvist/LibAPRS/pull/14.diff> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABXxPAShBN6tDN4_mzMVc_vAcRyD7OtPks5uAkUAgaJpZM4U4Drh>.

— You are receiving this because you authored the thread. Reply to this email directly, <#14 (comment)> view it on GitHub, or <https://github.com/notifications/unsubscribe-auth/AiL4tzCRryytlWtnghfJD4LOjmdf8Mn8ks5uDwxFgaJpZM4U4Drh> mute the thread.