Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small compatibility fix for Craft 3.5 #338

Closed
redboer opened this issue Aug 13, 2020 · 1 comment · Fixed by #339
Closed

Small compatibility fix for Craft 3.5 #338

redboer opened this issue Aug 13, 2020 · 1 comment · Fixed by #339

Comments

@redboer
Copy link
Contributor

redboer commented Aug 13, 2020

Please refactor the use of private $request in ApiController since newer version of Craft uses this.

"Access level to markhuot\CraftQL\Controllers\ApiController::$request must be public (as in class craft\web\Controller)"

Removing it should be ok since it's not used it seems.
brandonkelly added a commit to brandonkelly/craftql that referenced this issue Aug 13, 2020
@brandonkelly
Fixed Craft 3.5 / Yii 2.0.36 compatibility
5133eb9 
markhuot\CraftQL\Controllers\ApiController::$request is never used, and conflicts with yii\base\Controller::$request

Fixes markhuot#338
@brandonkelly brandonkelly mentioned this issue Aug 13, 2020
Merged
@redboer
Copy link
Contributor Author

redboer commented Aug 14, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed Craft 3.5 / Yii 2.0.36 compatibility brandonkelly/craftql
1 participant
@redboer