"empty" values in dropdown fields

[timkelty]

I think you're "faking" this because enums can't be empty…

craftql/src/Helpers/StringHelper.php

Lines 28 to 37 in 950a641

	static function graphQLEnumValueForString($string): string {
	$string = preg_replace('/[^a-z0-9_]+/i', ' ', $string);
	$string = preg_replace_callback('/\s+(.)/', function ($match) {
	return ucfirst($match[1]);
	}, $string);
	if ($string === '') {
	$string = 'empty';
	}
	return $string;
	}

Can't they be null? Seems like that might be a better choice.

[markhuot]

Unfortunately an enum value's name can not be null… GraphQL, essentially, tracks enums like this,

$enum = [
  'name' => 'value',
  'fall' => 'fall',
  'SPRING' => 'spring',
  'All Year' => ''
]

The name from above is what you type in to a GraphQL query, such as,

{
  entry(enumField: name) {
    #...
  }
}

From the GraphQL spec the name must be a string. So, in the current configuration we end up with,

{
  addSport(season: empty) {
    #...
  }
}

In the above think of empty not as a string, "empty", but as a keyword for empty, if that makes sense.

--

Note: there was actually a bug here with how empty values were handled on upsets that is fixed on dev-master now.

[markhuot]

I'm going to leave this open until a stable tag is created.

[markhuot]

Closing this issue. The fix is included in version 1.2.1.