Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bare-version without included emojis or shortcuts #42

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Add bare-version without included emojis or shortcuts #42

merged 1 commit into from
Oct 1, 2020

Conversation

ErikMichelson
Copy link
Contributor

This PR introduces an export for a bare-version that does not ship the emoji or shortcut definitions alongside.
You might want to use it, if you're using custom definitions and want to keep the final bundle size as low as possible.

I had to set uglify-js in package.json to version 2, because the newer version 3 dropped support for the "preamble" parameter, resulting in failing build procedures.

Closes #41

@puzrin
Copy link
Member

puzrin commented Oct 1, 2020

Comments:

  1. don't touch dist
  2. IMO it worth arrange "index"/"light" via "bare"
  3. Some minimal test needed (now no proofs bare.js works at all).

@ErikMichelson
Copy link
Contributor Author

Done. :)

  • index and light are arranged via bare
  • dist files remain untouched
  • added test cases for bare version, coveralls reports 100% coverage
  • fixed a bug that an empty emoji definition caused 'undefined' to be inserted after every character

@puzrin
Copy link
Member

puzrin commented Oct 1, 2020

LGTM.

Could you join everything into single commit?

@ErikMichelson
Copy link
Contributor Author

Done

@puzrin puzrin merged commit 760985b into markdown-it:master Oct 1, 2020
@ErikMichelson ErikMichelson deleted the bare-version branch October 1, 2020 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add variant without bundled definitions
2 participants