Do not process empty abbreviations

Fix #6
markdown-it · Aug 31, 2016 · e75fd25 · e75fd25
1 parent 7ffc497
commit e75fd25
Show file tree

Hide file tree

Showing 3 changed files with 44 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+1.0.4 / 2016-08-31
+------------------
+
+- Fixed infinite loop caused by empty abbreviations like `*[]: foo`. Empty abbreviations are no longer parsed.
+
+
 1.0.3 / 2016-01-05
 ------------------
 

diff --git a/index.js b/index.js
@@ -48,6 +48,7 @@ module.exports = function sub_plugin(md) {
 
  label = state.src.slice(labelStart, labelEnd).replace(/\\(.)/g, '$1');
  title = state.src.slice(labelEnd + 2, max).trim();
+ if (label.length === 0) { return false; }
  if (title.length === 0) { return false; }
  if (!state.env.abbreviations) { state.env.abbreviations = {}; }
  // prepend ':' to avoid conflict with Object.prototype members

diff --git a/test/fixtures/abbr.txt b/test/fixtures/abbr.txt
@@ -111,6 +111,43 @@ Punctuation as a part of abbr
 .
 
 
+Trailing spaces inside abbreviation
+.
+*[ test ]: foo bar
+
+test test test
+test test test
+.
+<p>test test test
+test <abbr title="foo bar"> test </abbr> test</p>
+.
+
+
+Abbreviation that consists of only spaces
+.
+*[ ]: foo bar
+
+test test test
+test test test
+test test test
+.
+<p>test test test
+test test test
+test <abbr title="foo bar"> </abbr> test <abbr title="foo bar"> </abbr> test</p>
+.
+
+
+Empty abbreviations should not be processed as such
+.
+*[]: test
+
+(foo bar)
+.
+<p>*[]: test</p>
+<p>(foo bar)</p>
+.
+
+
 Security 1
 .
 *[__proto__]: blah