Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded Windows path seperator. #57

Closed
bastetfurry opened this issue Sep 18, 2018 · 1 comment
Closed

Hardcoded Windows path seperator. #57

bastetfurry opened this issue Sep 18, 2018 · 1 comment

Comments

@bastetfurry
Copy link

FluentDocker/Ductus.FluentDocker/Builders/FileBuilder.cs

Line 26 in 415e3f5

_workingFolder = @"${TEMP}\fluentdockertest\${RND}";

Shouldn't that use Path.Combine or at least Path.DirectorySeparatorChar?
Otherwise this is very Windows-centric code.
mariotoffia pushed a commit that referenced this issue Sep 18, 2018
Fixes issue #57 where path is hardcoded as windows.
1ef9600 
Now TemplateString to translate unix separator (when running on windows)
to windows separator and therefore it is possible to express unix and
mac path and still include windows paths (as long they are relative).
@mariotoffia
Copy link
Owner

@bastetfurry It should be resolved now. If you experience any more problem I'll open this issue again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mariotoffia @bastetfurry