Renamed SASL to sasl according to protocol definition for SASL plain … (

jbmusso#97) * Renamed SASL to sasl according to protocol definition for SASL plain text authentication. Now using Buffer object to create the UTF-8 byte encoding * removing utf8 library dependency
marcushill · Dec 18, 2017 · e9c4594 · e9c4594
1 parent 8675c99
commit e9c4594
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/gremlin-client/package.json b/gremlin-client/package.json
@@ -49,7 +49,6 @@
  "lodash": "^3.10.1",
  "node-uuid": "^1.4.3",
  "readable-stream": "^2.0.2",
- "utf8": "^2.0.0",
  "ws": "^2.3.1",
  "zer": "^0.1.0"
  },

diff --git a/gremlin-client/src/GremlinClient.js b/gremlin-client/src/GremlinClient.js
@@ -6,7 +6,6 @@ import uuid from 'node-uuid';
 import _ from 'lodash';
 import highland from 'highland';
 import { gremlin, renderChain } from 'zer';
-import utf8 from 'utf8';
 
 import WebSocketGremlinConnection from './WebSocketGremlinConnection';
 import MessageStream from './MessageStream';
@@ -243,7 +242,8 @@ class GremlinClient extends EventEmitter {
 
  buildChallengeResponse(requestId) {
  const { processor, op, accept, language, aliases } = this.options;
- var args = { SASL: utf8.encode('\0' + this.user + '\0' + this.password) };
+ var saslbase64 = new Buffer('\0' + this.user + '\0' + this.password).toString('base64');
+ var args = { sasl: saslbase64 }
 
  const message = {
  requestId: requestId,