feat: Sidebar component
#513
Conversation
# Conflicts: # crates/hooks/src/use_theme.rs # examples/sidebar.rs
# Conflicts: # .github/workflows/rust.yml # README.md # crates/components/src/external_link.rs # crates/components/src/scroll_views/scroll_bar.rs # crates/components/src/slider.rs # crates/core/src/types.rs # crates/core/tests/pointer_events.rs # crates/elements/src/_docs/size_unit.rs # crates/freya/src/_docs/animating.rs # crates/freya/src/_docs/hot_reload.rs # crates/freya/src/_docs/theming.rs # crates/freya/src/launch.rs # crates/freya/src/lib.rs # crates/hooks/src/rope_editor.rs # crates/hooks/src/use_accessibility.rs # crates/hooks/src/use_animation.rs # crates/hooks/src/use_editable.rs # crates/renderer/src/app.rs # crates/renderer/src/event_loop.rs # crates/renderer/src/lib.rs # crates/renderer/src/window.rs # crates/testing/src/launch.rs # crates/testing/src/test_handler.rs # crates/torin/src/values/size.rs # examples/canvas.rs # examples/cloned_editor.rs # examples/editor.rs # examples/installer/src/main.rs # examples/opacity.rs # examples/sidebar.rs # examples/text.rs # examples/viewport.rs # examples/virtual_scroll_view.rs
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
==========================================
- Coverage 54.22% 54.01% -0.21%
==========================================
Files 154 153 -1
Lines 13732 13678 -54
==========================================
- Hits 7446 7388 -58
- Misses 6286 6290 +4 ☔ View full report in Codecov by Sentry. |
|
let me see what I can do to fix the git thing |
|
might be a line ending thing, what OS do you have? What does this give you? |
Nothing. I'm on Windows 10. I mean all the changed files are just copied from main because I couldn't properly merge main into the branch 😅 |
Wdym by nothing? |
I ran it again and this is what it gave me: |
What version of git do you have? |
2.39.1.windows.1 but I just use GitHub desktop |
|
let me now fix this |
|
Nice work @tigerros 😄 |
This finishes and updates #383. I've removed the router integration from
SidebarItemin favor of the user just passing in aLinkas the children. Therouterexample can be run but the buttons are not functional at the moment because #411 is not merged yet (theLinkis in the example, just commented out). Once #411 is merged, this can be merged too.Sorry for the terrible git history, I really don't know what I'm doing when it comes to git.