Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bundle button for normal users and disable bundling functionality in read only mode #2338

Merged
merged 1 commit into from
May 15, 2024

Conversation

CollinBeczak
Copy link
Collaborator

Issue fixed: Normal users would not be able to see the bundle button; only super users could. Also, the button still showed up in read-only mode, and the hotkeys also worked.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 23.37%. Comparing base (47ca2d1) to head (cf85104).
Report is 1 commits behind head on main.

Files Patch % Lines
...nents/Widgets/TaskBundleWidget/TaskBundleWidget.js 0.00% 1 Missing and 2 partials ⚠️
...c/components/HOCs/WithTaskBundle/WithTaskBundle.js 0.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2338      +/-   ##
==========================================
- Coverage   23.37%   23.37%   -0.01%     
==========================================
  Files         648      648              
  Lines       22720    22722       +2     
  Branches     7029     7044      +15     
==========================================
  Hits         5311     5311              
- Misses      14545    14546       +1     
- Partials     2864     2865       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CollinBeczak CollinBeczak merged commit 95b3a60 into main May 15, 2024
4 checks passed
@CollinBeczak CollinBeczak deleted the fix-bundle-button-for-normal-users branch May 15, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants