Collect GL and Bundle size stats. Revert #10161 #10332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8e7e849.
I found a script that ran through all release tags, fetching the bundle from CDN, and ran GL stats on it. In this case we need a different one that would go commit by commit, running |
mourner
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores the collect-stats CI job. This collects basic WebGL usage stats and bundle size information that is used for internal tooling.
It was tested with a temporary commit in this branch, but is only enabled for commits to
main. Example working commit: https://app.circleci.com/pipelines/github/mapbox/mapbox-gl-js/5696/workflows/c1f8f2bf-991a-4bf3-b1d8-9233cf113ebd/jobs/77968What remains to be done is run through all the commits introduced in #10160 to account for missing data from those commits until right before this PR is merged. @mourner did you have a driver script for doing this from the initial implementation.