Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two different artifacts when using patterns with data driven styling.
(Don't conditionally set uniforms binders, this may lead to potential visual artifacts during frame with stale data (The reason of the artifacts mentioned in Patterns computed from zoom-based expressions render with incorrect scale #10033 (comment), this may happen sporadically when the data is changing between zoom levels). For such frames, the uniforms are simply set to only sample from the valid texture, instead of using an older uniform value.)
EDIT: This needs to be addressed separately by fixing atlas dependencies instead
Fix order of pattern_attribute, must match the CrossFadedCompositeBinder names (Fixes issue of described in Patterns computed from zoom-based expressions render with incorrect scale #10033 (comment), which may invert from and to)
Launch Checklist
mapbox-gl-js
changelog:<changelog>Fix inconsistent behavior of patterns while using data driven styling</changelog>