sds: on destroy, validate NULL

Signed-off-by: Eduardo Silva <[email protected]>
manuelluis · Jun 20, 2018 · 38a0d83 · 38a0d83
1 parent e1bb870
commit 38a0d83
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/include/fluent-bit/flb_sds.h b/include/fluent-bit/flb_sds.h
@@ -82,6 +82,6 @@ flb_sds_t flb_sds_cat(flb_sds_t s, char *str, int len);
 flb_sds_t flb_sds_increase(flb_sds_t s, size_t len);
 flb_sds_t flb_sds_copy(flb_sds_t s, char *str, int len);
 
-int flb_sds_destroy(flb_sds_t s);
+void flb_sds_destroy(flb_sds_t s);
 
 #endif
diff --git a/src/flb_sds.c b/src/flb_sds.c
@@ -157,12 +157,14 @@ flb_sds_t flb_sds_copy(flb_sds_t s, char *str, int len)
  return s;
 }
 
-int flb_sds_destroy(flb_sds_t s)
+void flb_sds_destroy(flb_sds_t s)
 {
  struct flb_sds *head;
 
+ if (!s) {
+ return;
+ }
+
  head = FLB_SDS_HEADER(s);
  flb_free(head);
-
- return 0;
 }