Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug "Invalid configuration setting: verbose" #14

Closed
fonsecas72 opened this issue Feb 10, 2016 · 2 comments
Closed

Bug "Invalid configuration setting: verbose" #14

fonsecas72 opened this issue Feb 10, 2016 · 2 comments
Labels

Comments

@fonsecas72
Copy link
Contributor

Hi, I have introduced a bug in your library.
When you call the analyze command in verbose mode, e.g. "bin/phpda analyze phpda.yml.dist -v"
The following exception is throw

  [InvalidArgumentException]              
  Invalid configuration setting: verbose 

This happens because we are passing all the input to the Config class.
Before trying to fix it I wanted to know what do you think.

@fonsecas72 fonsecas72 changed the title bug "Invalid configuration setting: verbose" Bug "Invalid configuration setting: verbose" Feb 10, 2016
@mamuz
Copy link
Owner

mamuz commented Feb 10, 2016

I suggest to remove the implementation of PR11.

The effort to fix this issue compared to the value of PR11 is to high.

I also think that would make it more future proof.

fonsecas72 pushed a commit to fonsecas72/PhpDependencyAnalysis that referenced this issue Feb 10, 2016
mamuz added a commit that referenced this issue Feb 10, 2016
@mamuz mamuz closed this as completed Feb 10, 2016
@fonsecas72
Copy link
Contributor Author

I agree.
Also: I think we should definitely protect our selves from this issue in the future.

@mamuz mamuz added the bug label Feb 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants