Vmp3700 Raf Electronics Videokê #7839

felipesanches · 2021-03-04T13:16:50Z

Back in 2017 I started drafting a driver for the Raf Electronics VMP3700 videoke. I've then shelved this pet-project for many years and by September 2020 I gave it a second chance by rebasing the old commits against git master and then attempting to update the code-style to re-sync with MAME's current codebase.

Yesterday a friend asked me about this project and I decided to make it public "as is" so that it is not lost forever in a branch of my local copy on my laptop.

Unfortunately, there is one portion of that code that I was not able to update properly, which involves the implementation of the 386EX device, which is basically a 386 CPU with some other typical PC chipset all included in a single chip (this is a simplistic description, but gives you a general idea of what this is about). I'd like to ask for some help here to at least fix build. I know that there may be many code-style tweaks that may be needed to make this PR acceptable for merge, and I will address them, but this is not yet a PR intended for merging. I want to just fix the build so that I can get back to studying the device. The ability to run its boot code and inspect it on MAME's debugger is very important in helping me to figure out other aspects of the emulation that still need to be implemented or fixed.

I plan to get back to it on my free time during this weekend. Any feedback on this preliminary set of commits will be much appreciated.

cheers!

* Sketched an initial Vmp3700 driver * Determined the mapping of the chip-select signals * Declared the ROMs (including 2 undumped maskroms which are soldered to the PCB) * Started working on an Intel 386EX processor driver. * Hooked up the internal I/O maps for the embedded i386EX interrupt controllers (master and slave PIC8259). * Mapped the bank-switching high-address bits for the maskroms (a few Port 3 bits)

* Parallel Port I/O handlers (boilerplate code) * helper method to print bit patterns in log messages * PINCFG (Pin Configuration) * implementing a few more boilerplate code of configuration registers * parse chip-select-unit register values + mem map tweaks + frontpanel mcu + misc changes * set clock prescaler

…ME codebase as lots of things changed since 2017

happppp · 2021-03-04T14:04:42Z

Could you move the device to i386ex.cpp and i386ex.h or is there a conflict with macros?
Also, MAME's default is 4 spaces=1 tab. your 8 spaces would be converted to 2 tabs by our srcclean tool.

villedevs · 2021-03-04T15:28:06Z

Is the FETCH() replacement really necessary?

cuavas · 2021-03-06T14:03:19Z

This definitely needs cleanup, and the 386ex should be moved out to a separate file. Pulling in all the peripheral chip headers for everything using the 386 is undesirable.

felipesanches · 2021-03-09T05:55:02Z

OK, I can do the refactoring you suggested, for sure.

But can someone tell me why this does not build properly (regardless of code-style cleanup considerations)? I recall I gave up late last year after trying for a few days to update the code to the newest code-base.

Osso13 · 2021-03-09T10:42:58Z

OK, I can do the refactoring you suggested, for sure.

But can someone tell me why this does not build properly (regardless of code-style cleanup considerations)? I recall I gave up late last year after trying for a few days to update the code to the newest code-base.

It compiled and linked fine here, what error are you getting?

felipesanches · 2021-03-10T02:55:16Z

It compiled and linked fine here, what error are you getting?

Interesting! Maybe it was a runtime error then. I will get back to it later (probably on the weekend) so that I can better describe what's wrong. Last time I touched this code was circa September 2020 if I recall correctly

…ETCH override

felipesanches · 2021-03-14T02:31:36Z

I've just updated the code to cleanup indentation, to move the 386EX into separate .cpp/.h files, and to remove the FETCH override.

The problem is a SegFault at runtime:

felipesanches · 2021-03-14T11:23:57Z

what's the purpose of the i386_device::mem_pr8 method and why would it crash here?

villedevs · 2021-03-14T21:22:07Z

I think the problem is, the memory accessors need overrides for 16-bit bus.
From i386sx_device:
virtual u8 mem_pr8(offs_t address) override { return macache16.read_byte(address); };
virtual u16 mem_pr16(offs_t address) override { return macache16.read_word(address); };
virtual u32 mem_pr32(offs_t address) override { return macache16.read_dword(address); };

Or you could just derive the class from i386sx_device instead.

felipesanches · 2021-03-15T06:34:39Z

I will try the overrides later and I'll let you know if it worked well. Thanks a lot!

…lledevs

…lledevs at mamedev#7839 (comment)

felipesanches · 2021-03-17T07:18:27Z

yes, it worked! Thanks, @villedevs

…lledevs

…lledevs at mamedev#7839 (comment)

felipesanches · 2021-03-20T06:16:39Z

Please consider merging this preliminary work, as-is, since I do not plan to continue working on it on the short-term. I may revisit it on the future for further improvements, though.

felipesanches · 2021-03-20T06:17:51Z

I'll be happy to make minor tweaks in order to get this merged, of course! Please, let me know.

cuavas · 2021-04-08T16:37:10Z

src/devices/cpu/i386/i386ex.cpp

@@ -0,0 +1,316 @@
+#include "i386ex.h"


This file is missing the standard header comment, and the PCH.

what is PCH?

cuavas · 2021-04-08T16:39:25Z

src/devices/cpu/i386/i386ex.cpp

+{
+ zero_state();


Is it necessary to avoid calling i386_device::device_reset? It’s usually better to call the base device_reset and patch up things that need to be different.

smf- · 2021-05-26T20:20:47Z

All .cpp files should start with #include "emu.h" When building with gcc/clang emu.h is precompiled and injected into every .cpp, so it will compile regardless without it (unless you disable precompiled headers with a command line parameter) but it will fail to compile with visual studio.

…

On 25/05/2021 18:37, Felipe Corrêa da Silva Sanches wrote: ***@***.**** commented on this pull request. ------------------------------------------------------------------------ In src/devices/cpu/i386/i386ex.cpp <#7839 (comment)>: > @@ -0,0 +1,316 @@ +#include "i386ex.h" what is PCH? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#7839 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACGVYYQFVM65TDMRWJRQ5GLTPPN5XANCNFSM4YTHO2PQ>.

felipesanches · 2021-05-26T20:25:33Z

Oh, I see! I was not aware of that. Thanks for the clarification ;-)

felipesanches added 4 commits March 4, 2021 09:46

updating the vmp3700 driver (and i386ex cpu_device) to the current MA…

1171529

…ME codebase as lots of things changed since 2017

this is shit! Must be reviewed before resuming work on this device

aa3ffa1

felipesanches force-pushed the vmp3700_videoke branch from 33cf6e3 to 3564ba8 Compare March 14, 2021 02:16

fix indentation, split 386EX into separate .cpp/.h files and remove F…

23d19d3

…ETCH override

felipesanches force-pushed the vmp3700_videoke branch from 3564ba8 to 23d19d3 Compare March 14, 2021 02:23

wip

6a80605

felipesanches added a commit to felipesanches/mame that referenced this pull request Mar 17, 2021

fix crash by adding these memory access overrides as suggested by @vi…

b726c0e

…lledevs at mamedev#7839 (comment)

felipesanches marked this pull request as ready for review March 17, 2021 07:18

fix crash by adding these memory access overrides as suggested by @vi…

5f42b85

…lledevs at mamedev#7839 (comment)

felipesanches force-pushed the vmp3700_videoke branch from b726c0e to 5f42b85 Compare March 17, 2021 07:26

cuavas reviewed Apr 8, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vmp3700 Raf Electronics Videokê #7839

Vmp3700 Raf Electronics Videokê #7839

felipesanches commented Mar 4, 2021

happppp commented Mar 4, 2021

villedevs commented Mar 4, 2021

cuavas commented Mar 6, 2021

felipesanches commented Mar 9, 2021

Osso13 commented Mar 9, 2021

felipesanches commented Mar 10, 2021

felipesanches commented Mar 14, 2021

felipesanches commented Mar 14, 2021

villedevs commented Mar 14, 2021

felipesanches commented Mar 15, 2021

felipesanches commented Mar 17, 2021

felipesanches commented Mar 20, 2021

felipesanches commented Mar 20, 2021

cuavas Apr 8, 2021

felipesanches May 25, 2021

cuavas Apr 8, 2021

smf- commented May 26, 2021 via email

felipesanches commented May 26, 2021

Vmp3700 Raf Electronics Videokê #7839

Are you sure you want to change the base?

Vmp3700 Raf Electronics Videokê #7839

Conversation

felipesanches commented Mar 4, 2021

happppp commented Mar 4, 2021

villedevs commented Mar 4, 2021

cuavas commented Mar 6, 2021

felipesanches commented Mar 9, 2021

Osso13 commented Mar 9, 2021

felipesanches commented Mar 10, 2021

felipesanches commented Mar 14, 2021

felipesanches commented Mar 14, 2021

villedevs commented Mar 14, 2021

felipesanches commented Mar 15, 2021

felipesanches commented Mar 17, 2021

felipesanches commented Mar 20, 2021

felipesanches commented Mar 20, 2021

cuavas Apr 8, 2021

Choose a reason for hiding this comment

felipesanches May 25, 2021

Choose a reason for hiding this comment

cuavas Apr 8, 2021

Choose a reason for hiding this comment

smf- commented May 26, 2021 via email

felipesanches commented May 26, 2021